Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize autofill security concern mitigation copy #3323

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

graeme
Copy link
Collaborator

@graeme graeme commented Sep 20, 2024

Task/Issue URL: https://app.asana.com/0/1199230911884351/1208341864628591/f

Description:

Localizations for https://app.asana.com/0/1199230911884351/1208316169332403

Steps to test this PR:

  1. Switch to another language and step through the screens from here to check they've been translated

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@graeme graeme marked this pull request as ready for review September 20, 2024 15:37
@graeme graeme requested a review from amddg44 September 20, 2024 15:37
Copy link
Contributor

@amddg44 amddg44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translations all look good, but something is up with the URL that is loaded from the “Learn more” link in the popover 🙂

image

@graeme graeme merged commit 40540c7 into main Sep 23, 2024
18 checks passed
@graeme graeme deleted the graeme/address-autofill-security-concerns-localizations branch September 23, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants